Skip to content

Commit 017e1e6

Browse files
Niekpthier
authored and
pthier
committed
[nodejs#11570] Disable Proxy test in parallel/test-v8-serdes.js
See: https://bugs.chromium.org/p/v8/issues/detail?id=11570 This PR disables the Proxy test in test/parallel/test-v8-serdes.js while https://chromium-review.googlesource.com/c/v8/v8/+/2739980 is being merged. Will do another PR to re-enabled the (fixed) test once the 2739980 has landed.
1 parent 49bf5f6 commit 017e1e6

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/parallel/test-v8-serdes.js

+4
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,9 @@ const hostObject = new (internalBinding('js_stream').JSStream)();
4747
}
4848
}
4949

50+
/*
51+
// TODO(v8:11570): We disable the following test, while https://chromium-review.googlesource.com/c/v8/v8/+/2739980 is being merged
52+
// After merging, a follow-up PR will be made to re-enable this test with changed behavior
5053
{
5154
const ser = new v8.DefaultSerializer();
5255
ser._getDataCloneError = common.mustCall((message) => {
@@ -60,6 +63,7 @@ const hostObject = new (internalBinding('js_stream').JSStream)();
6063
ser.writeValue(new Proxy({}, {}));
6164
}, /foobar/);
6265
}
66+
*/
6367

6468
{
6569
const ser = new v8.DefaultSerializer();

0 commit comments

Comments
 (0)