Skip to content

Commit eaa2371

Browse files
Niekpthier
authored and
pthier
committed
[nodejs#11570] Disable Proxy test in parallel/test-v8-serdes.js
See: https://bugs.chromium.org/p/v8/issues/detail?id=11570 This PR disables the Proxy test in test/parallel/test-v8-serdes.js while https://chromium-review.googlesource.com/c/v8/v8/+/2739980 is being merged. Will do another PR to re-enabled the (fixed) test once the 2739980 has landed.
1 parent 82ea3c1 commit eaa2371

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

test/parallel/test-v8-serdes.js

+4
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,9 @@ const hostObject = new (internalBinding('js_stream').JSStream)();
5555
}
5656
}
5757

58+
/*
59+
// TODO(v8:11570): We disable the following test, while https://chromium-review.googlesource.com/c/v8/v8/+/2739980 is being merged
60+
// After merging, a follow-up PR will be made to re-enable this test with changed behavior
5861
{
5962
const ser = new v8.DefaultSerializer();
6063
ser._getDataCloneError = common.mustCall((message) => {
@@ -68,6 +71,7 @@ const hostObject = new (internalBinding('js_stream').JSStream)();
6871
ser.writeValue(new Proxy({}, {}));
6972
}, /foobar/);
7073
}
74+
*/
7175

7276
{
7377
const ser = new v8.DefaultSerializer();

0 commit comments

Comments
 (0)