Disabled Grid allows focusing cells using keyboard

[anezthes]

Description

A disabled Grid doesn't allow selecting items using pointing devices, but it is possible to select an item (at least visually) using keyboard.

Expected outcome

Selection should be fully disabled.

Actual outcome

Selection is possible using keyboard.

Minimal reproducible example

Grid<Item> grid = new Grid();
grid.addColumn(Item::getName).setHeader("Name");
grid.setEnabled(false);

ArrayList<Item> items = new ArrayList();
for (int i = 0; i < 10; i++) {
  items.add(new Item("Item " + i));
}
grid.setItems(items);

...

private class Item {

  String name;

  Item(String name) {
    this.name = name;
  }

  public String getName() {
    return name;
  }
}

Environment

• Vaadin 14.6.3 (Flow)
• macOS 11.2.3

Browsers Affected

• Chrome
• Firefox
• Safari
• Edge

[vlukashov]

NOTE: the vaadin-grid web-component does not have a disabled mode at all.

[rolfsmeds]

Changed the title to refer to cell focus rather than selection, as selection is correctly disabled, but cell focus works normally (both with mouse and keyboard, although only the latter has a visual indication).

Question is: Should cell focus, or indeed all focus, be disabled when the Grid is disabled?

[rolfsmeds]

Related: col sort arrows are togglable in disabled grid (sorting doesn't happen, but the arrow states change) #1555

[rolfsmeds]

Ping @jouni @tomivirkki for comments.

[tomivirkki]

Grid shouldn't have setEnabled API in the first place, because <vaadin-grid> doesn't have disabled mode/feature either (as stated above).

I'd be in favor of first designing how <vaadin-grid disabled> should work in general and then implementing it in the Web Component as a feature. Once the feature is in place, the disabled mode should be taken into account whenever a new feature gets added to <vaadin-grid> to avoid inconsistent behavior, like the one in question, between the Flow and Web components.

In case disabled doesn't make sense for <vaadin-grid>, the erroneous setEnabled API could just be removed from the Flow Grid.

[DiegoCardoso]

In case disabled doesn't make sense for , the erroneous setEnabled API could just be removed from the Flow Grid.

I guess disabled makes sense to Flow Grid because of the Editor:

grid-disabled.mp4

[tomivirkki]

If it's only required for the editor (another Flow-only feature), there could be a dedicated API for disabling/enabling the editor.

[rolfsmeds]

Created a separate ticket for implementing a proper disabled state in vaadin-grid. Closing this in favor of that.