Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

GridPro: Enable edit mode in custom editors with keypress #5931

Open
OlliTietavainenVaadin opened this issue Jan 11, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@OlliTietavainenVaadin
Copy link
Member

Describe your motivation

The built-in GridPro editors allow you to start typing, which is a nice UX. Currently, you can't do this with custom editors; you need to double-click or press enter to start editing.

Describe the solution you'd like

It should be possible to start typing to enter the values regardless of editor type.

Describe alternatives you've considered

The behavior (old "requires doubleclick or enter" / new "just start typing") could be configurable? Not sure who would prefer the old one, though.

Additional context

Related issue: #2185

The web component has hardcoded keydown listener logic: https://github.com/vaadin/web-components/blob/e4f1628417f2fdbd5bd3b95e98822a6728a95603/packages/grid-pro/src/vaadin-grid-pro-inline-editing-mixin.js#L110-L112
And then the type passed to _enterEditFromEvent is checked here
https://github.com/vaadin/web-components/blob/e4f1628417f2fdbd5bd3b95e98822a6728a95603/packages/grid-pro/src/vaadin-grid-pro-inline-editing-mixin.js#L283-L285

@yuriy-fix yuriy-fix added the enhancement New feature or request label Jan 11, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants