From 777929d5153d318afafaaa162daa9497af6d3203 Mon Sep 17 00:00:00 2001 From: Artur Date: Wed, 4 Dec 2024 14:13:21 +0200 Subject: [PATCH 1/2] fix: Remove timeout for browser websocket connection for Vite --- .../base/devserver/viteproxy/ViteWebsocketEndpoint.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java b/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java index fb1e6a7f90a..be2e1e4b1d6 100644 --- a/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java +++ b/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java @@ -85,8 +85,9 @@ public static void init(VaadinContext context, ViteHandler viteHandler) { public void onOpen(Session session, EndpointConfig config) { getLogger().debug("Browser ({}) connected to Vite proxy", session.getId()); - session.setMaxIdleTimeout(60000); // Vite pings every 30s so this needs - // to be larger + // Vite pings every 30s but while you debug in the browser, the pings will be prevented. + // When you resume after debugging, the page will reload if the timeout was hit, so it is 0 == disabled + session.setMaxIdleTimeout(0); ViteHandler viteHandler = (ViteHandler) config.getUserProperties() .get(VITE_HANDLER); From 68ae6b86110dda30367ff3637a55156e65ad07c2 Mon Sep 17 00:00:00 2001 From: Artur Signell Date: Wed, 4 Dec 2024 14:21:52 +0200 Subject: [PATCH 2/2] format --- .../base/devserver/viteproxy/ViteWebsocketEndpoint.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java b/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java index be2e1e4b1d6..eccb2275611 100644 --- a/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java +++ b/vaadin-dev-server/src/main/java/com/vaadin/base/devserver/viteproxy/ViteWebsocketEndpoint.java @@ -85,8 +85,10 @@ public static void init(VaadinContext context, ViteHandler viteHandler) { public void onOpen(Session session, EndpointConfig config) { getLogger().debug("Browser ({}) connected to Vite proxy", session.getId()); - // Vite pings every 30s but while you debug in the browser, the pings will be prevented. - // When you resume after debugging, the page will reload if the timeout was hit, so it is 0 == disabled + // Vite pings every 30s but while you debug in the browser, the pings + // will be prevented. + // When you resume after debugging, the page will reload if the timeout + // was hit, so it is 0 == disabled session.setMaxIdleTimeout(0); ViteHandler viteHandler = (ViteHandler) config.getUserProperties()