Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Include the error in the onError callback of Subscription #2062

Closed
peholmst opened this issue Feb 12, 2024 · 0 comments · Fixed by #2987
Closed

Include the error in the onError callback of Subscription #2062

peholmst opened this issue Feb 12, 2024 · 0 comments · Fixed by #2987
Assignees
Labels
enhancement New feature or request hilla Issues related to Hilla

Comments

@peholmst
Copy link
Member

Describe your motivation

When subscribing to a flux connection, if you leave out the onError callback and there is an error, Hilla will throw the error and you can see what it is in the console. However, if you provide a callback and there is an error, you will only know that there is an error but you have no idea what it is.

Describe the solution you'd like

Either Hilla should log the error regardless of whether there is a callback or not, or the error should be passed as a parameter to the callback.

Describe alternatives you've considered

No response

Additional context

No response

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request hilla Issues related to Hilla
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants