Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

React 19 support #688

Open
dumbmatter opened this issue Dec 6, 2024 · 2 comments
Open

React 19 support #688

dumbmatter opened this issue Dec 6, 2024 · 2 comments

Comments

@dumbmatter
Copy link

dumbmatter commented Dec 6, 2024

It seems that the current version of ink does not work with React 19. For example with some minimal code like this:

import React from 'react';
import {render, Text} from 'ink';

render(React.createElement(Text, null, "Hello world"));

I get this output with react 18.3.1:

$ node index.js
Hello world

And this with react 19.0.0:

$ node index.js
/home/user/ink-react-19/node_modules/.pnpm/react-reconciler@0.29.2_react@19.0.0/node_modules/react-reconciler/cjs/react-reconciler.development.js:491
var ReactCurrentOwner = ReactSharedInternals.ReactCurrentOwner;
                                             ^

TypeError: Cannot read properties of undefined (reading 'ReactCurrentOwner')
    at $$$reconciler (/home/user/ink-react-19/node_modules/.pnpm/react-reconciler@0.29.2_react@19.0.0/node_modules/react-reconciler/cjs/react-reconciler.development.js:491:46)
    at file:///home/user/ink-react-19/node_modules/.pnpm/ink@5.1.0_react@19.0.0/node_modules/ink/build/reconciler.js:61:16

Node.js v22.11.0
@marviobezerra
Copy link

Same here

@MattyBalaam
Copy link

Is someone using React internals? Hope they don't get fired.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants