Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing validation for Macedonian phone numbers #2497

Open
energet1k opened this issue Nov 14, 2024 · 5 comments
Open

Missing validation for Macedonian phone numbers #2497

energet1k opened this issue Nov 14, 2024 · 5 comments

Comments

@energet1k
Copy link

Explanation
validator.isMobilePhone cannot validate a good (valid) Macedonian phone number.

The macedonian number starts with +389, and is followed by 8 digits, or if written with national prefix (0), it will be 9 digits in length.

Additional context
Validator.js version: v.13.11.0
Node.js version: v23.1.0

@rubiin
Copy link
Member

rubiin commented Nov 14, 2024

pr are welcome

@energet1k
Copy link
Author

not exactly sure which file should be modified? could you point it out please? @rubiin

@rubiin
Copy link
Member

rubiin commented Nov 14, 2024

you can check this PR https://github.com/validatorjs/validator.js/pull/2395/files to see the files you need to change , also the necessary changes

@eshward95
Copy link

Can you assign this to me working on the fix for this @rubiin

@eshward95
Copy link

@rubiin PR #2500

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants