Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Usage of MASTER in module reference #249

Closed
madolson opened this issue Apr 7, 2024 · 2 comments · Fixed by #262
Closed

Usage of MASTER in module reference #249

madolson opened this issue Apr 7, 2024 · 2 comments · Fixed by #262
Labels
polish typos, style, etc

Comments

@madolson
Copy link
Member

madolson commented Apr 7, 2024

We still have a usage of master in modules,

valkey/src/module.c

Line 11514 in 717ec1e

* * ValkeyModuleEvent_MasterLinkChange
, even though we attempted to remove it. Was this a miss @PingXie, or is there some reason we have to keep it?
@madolson madolson added the polish typos, style, etc label Apr 7, 2024
@9bany
Copy link
Contributor

9bany commented Apr 8, 2024

Can i pick up this issue ? @madolson
I have a question, "we attempted to remove it" -> did you mean rename it or move it to another Module ?
p/s: ValkeyModuleEvent_MasterLinkChange event is used by ValkeyModuleEvent module.

@madolson
Copy link
Member Author

madolson commented Apr 8, 2024

@0del Go for it

@9bany 9bany mentioned this issue Apr 8, 2024
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
polish typos, style, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ValkeyModuleEvent_MasterLinkChange to ValkeyModuleEvent_PrimaryLinkChange 9bany/valkey
2 participants
@madolson @9bany