Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

three-forcegraph and three-forcegraph updates break typescript build #692

Open
GKersten opened this issue Nov 4, 2024 · 0 comments
Open

Comments

@GKersten
Copy link

GKersten commented Nov 4, 2024

Describe the bug
After regenerating package-lock I found my build broken with recent updates on 3d-force-graph and three-forcegraph.

Multiple TS errors, but for example:

TS2315: Type 'LinkObject' is not generic. [plugin angular-compiler]
node_modules/3d-force-graph/dist/3d-force-graph.d.ts:19:102:
19 │ ... NodeObject = NodeObject, L extends LinkObject = LinkObject>

After pinpointing I figured out the cause was with a combination of these packages being updated.

Working scenario, but fixed dependencies

Stackblitz: https://stackblitz.com/edit/4nxu3z-vdpcuy

"Fixed" & working package.json, notice that I did include "three-forcegraph"

  "dependencies": {
   ...
    "3d-force-graph": "1.73.4",
    "three-forcegraph": "1.41.15",
   ...
  }

Failing scenario: force-graph-3d v1.73.5 (fixed three-forcegraph to v1.41.15 dependency)

Stackblitz: https://stackblitz.com/edit/4nxu3z-jfhk4g

Failing scenario, 3d-force-graph v1.73.4 with non-fixed three-forcegraph (v1.42.2)

Stackblitz: https://stackblitz.com/edit/4nxu3z-utov1u

To Reproduce
See stackblitz, only difference is in package.json / package-lock.json

Expected behavior
Build to succeed

Screenshots
image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: chrome
  • Version: 130.0.6723.92 (Official Build) (64-bit)
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant