Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Additional component update triggered by root_scene.userData.dirty = true in afterUpdate #111

Closed
vatro opened this issue Jun 21, 2022 · 1 comment
Closed

Additional component update triggered by root_scene.userData.dirty = true in afterUpdate #111

vatro opened this issue Jun 21, 2022 · 1 comment
Assignees
@vatro
Labels
bug Something isn't working performance
Milestone
1.0.0-next.1

Comments

@vatro
Copy link
Owner

vatro commented Jun 21, 2022

not good, fix.
@vatro vatro added bug Something isn't working performance labels Jun 21, 2022
@vatro vatro self-assigned this Jun 21, 2022
@vatro
Copy link
Owner Author

vatro commented Jun 21, 2022

fix candidate:

// prevent an additional component update by not accessing the `root_scene` prop directly.
root_scene_obj.value.userData.dirty = true

@vatro vatro mentioned this issue Jul 2, 2022
Closed
@vatro vatro added this to the 1.0.0-next.1 milestone Aug 5, 2022
@vatro vatro mentioned this issue Aug 5, 2022
Open
17 tasks
@vatro vatro closed this as completed in ba05cee Aug 9, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@vatro vatro

Labels
bug Something isn't working performance
Projects
None yet
Milestone
1.0.0-next.1
Development

No branches or pull requests
1 participant
@vatro