Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

OrbitControls check / implement instance injection #126

Open
vatro opened this issue Aug 9, 2022 · 0 comments
Open

OrbitControls check / implement instance injection #126

vatro opened this issue Aug 9, 2022 · 0 comments
Assignees
@vatro
Labels
check / polish decision needed refactor
Milestone
1.0.0-next.X

Comments

@vatro
Copy link
Owner

vatro commented Aug 9, 2022 •
edited
Loading

Instance ( orbitcontrols? ) injection needs to be nailed down / reconsidered.

Currently related logic is being imported but is unused:
import { if$_instance_change } from "../logic/if$"
import { ..., find_in_canvas } from "../logic/shared"
@vatro vatro self-assigned this Aug 9, 2022
@vatro vatro added this to the 1.0.0-next.1 milestone Aug 9, 2022
@vatro vatro modified the milestones: 1.0.0-next.1, 1.0.0-next.X Aug 9, 2022
@vatro vatro mentioned this issue Aug 11, 2022
Closed
vatro pushed a commit that referenced this issue Aug 19, 2022
OrbitControls remove unused instance injection related imports (#143)
5bc83e9 
instance injection isn't implemented yet. see #126
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@vatro vatro

Labels
check / polish decision needed refactor
Projects
None yet
Milestone
1.0.0-next.X
Development

No branches or pull requests
1 participant
@vatro