Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Run svelte-check + fix errors / warnings / hints before renaming Object3D component to Obj3D #143

Closed
vatro opened this issue Aug 18, 2022 · 0 comments
Closed

Run svelte-check + fix errors / warnings / hints before renaming Object3D component to Obj3D #143

vatro opened this issue Aug 18, 2022 · 0 comments
Assignees
@vatro
Labels
code quality
Milestone
1.0.0-next.1

Comments

@vatro
Copy link
Owner

vatro commented Aug 18, 2022 •
edited
Loading

Maybe this will fix something concerning #141 ? 🤷‍♂️
@vatro vatro added this to the 1.0.0-next.1 milestone Aug 18, 2022
@vatro vatro self-assigned this Aug 18, 2022
vatro pushed a commit that referenced this issue Aug 19, 2022
[WIP 1] #143
3e6ba21 
- Do not import (currently) unused `SvelthreeAnimationFunctionReturn` type

- Do not import unused type `Writable`

- Remove `await` before `remove_instance(...)` call. `remove_instance` is not an async function (probably was at some point).

- `CubeCamera` remove unused type `OnlyWritableNonFunctionProps`

- `Canvas` comment out currently unused `name` attribute

- `AmbientLight` remove unused `w_sh`

- `Canvas` remove unused var `render_mode`. These are probably remains of a former concept.

- `Canvas` 'e' was declared but its value was never read
vatro pushed a commit that referenced this issue Aug 19, 2022
Revert "[WIP 1] #143"
896760a 
This reverts commit 3e6ba21.
vatro pushed a commit that referenced this issue Aug 19, 2022
Do not import (currently) unused SvelthreeAnimationFunctionReturn t…
26832a4 
…ype (#143)
vatro pushed a commit that referenced this issue Aug 19, 2022
Do not import unused type Writable (#143)
fa4342d
vatro pushed a commit that referenced this issue Aug 19, 2022
Remove await before remove_instance(...) call (#143)
e665053 
`remove_instance` is not an async function (probably was at some point).
vatro pushed a commit that referenced this issue Aug 19, 2022
CubeCamera remove unused type OnlyWritableNonFunctionProps (#143)
c87e6b9
vatro pushed a commit that referenced this issue Aug 19, 2022
Canvas comment out currently unused name attribute (#143)
dd51432
vatro pushed a commit that referenced this issue Aug 19, 2022
AmbientLight remove unused w_sh (#143)
82a8bd6
vatro pushed a commit that referenced this issue Aug 19, 2022
Canvas remove unused var render_mode (#143)
178c62c 
These are probably remains of a former concept.
vatro pushed a commit that referenced this issue Aug 19, 2022
Canvas on_interaction_1 'e' was declared but its value was never …
2dd7c60 
…read (#143)
vatro pushed a commit that referenced this issue Aug 19, 2022
CubeCamera replace EmptySvelthreeComponent type alias with `Objec…
a97629b 
…t3DSvelthreeComponent` type alias (#143)

Forgot to change this when `Empty` component was replaced, see #132

TODO: the `CubeCamera` should currently break in VS Code just like `Spotlight`, see #141 because we're using `Object3D` type (alias) and `THREE.Object3D` in a Union Type for `bind_pos` and `hide` attributes. Created new issues for this, see #144
vatro pushed a commit that referenced this issue Aug 19, 2022
LoadedGLTF remove unused instance injection related imports (#143)
d510371 
instance injection isn't implemented yet. see #124
vatro pushed a commit that referenced this issue Aug 19, 2022
OrbitControls remove unused instance injection related imports (#143)
5bc83e9 
instance injection isn't implemented yet. see #126
vatro pushed a commit that referenced this issue Aug 19, 2022
OrbitControls use declared index_in_orbitcontrols by introducing …
e58921e 
…`get_index_in_orbitcontrols()` method (#143)

May be useful -> to clarify. If not remove them both, see #145
vatro pushed a commit that referenced this issue Aug 19, 2022
LoadedGLTF remove unused fn_index: number parameter in `process_a…
9881e55 
…fterLoaded` method (#143)
vatro pushed a commit that referenced this issue Aug 19, 2022
Remove unused tick imports (#143)
4d95528
vatro pushed a commit that referenced this issue Aug 19, 2022
SvelthreeInteraction comment out unused logging related code (#143)
b08b409
vatro pushed a commit that referenced this issue Aug 19, 2022
SvelthreeInteraction comment out declared but unused `passive_event…
7e9446c 
…s` (#143)

Still not sure if we even need this / want to handle this like Svelte, see #146
vatro pushed a commit that referenced this issue Aug 19, 2022
Revert "SvelthreeInteraction comment out unused logging related code (
90d594f 
#143)"

This reverts commit b08b409.
vatro pushed a commit that referenced this issue Aug 19, 2022
SvelthreeInteraction fix logging related code parts (#143)
94af418
vatro pushed a commit that referenced this issue Aug 19, 2022
SpotLight remove unused Euler and Quaternion imports (#143)
68a527a 
`SpotLight` is being primarily rotated by moving it's `.target`, clarify / check free rotation using `rot` (currently not implemented), see #147
vatro pushed a commit that referenced this issue Aug 19, 2022
SvelthreeInteraction change modifiers_arr typing / casting (#143)
0f1cad1 
Removes related svelte-check hints, untested in an app -> see #148
vatro pushed a commit that referenced this issue Aug 19, 2022
SvelthreeInteraction remove unused / obsolete register_event meth…
e88629c 
…od related code (#143)
vatro pushed a commit that referenced this issue Aug 19, 2022
SvelthreeInteraction add missing e types (#143)
22e2cee 
All inferred as `e: { detail: { event: PointerEvent } }`
vatro pushed a commit that referenced this issue Aug 19, 2022
SvelthreeInteraction add missing e types (#143)
dd6e122
vatro pushed a commit that referenced this issue Aug 20, 2022
OrbitControls remove unused browser import (#143)
80139e7
vatro pushed a commit that referenced this issue Aug 20, 2022
SvelthreeLightWithShadow remove unused logging related code (#143)
2413fc5 
TODO: we want to get rid of the `SvelthreeLightWithShadow` -> see #149
@vatro vatro closed this as completed in fa85ff4 Aug 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@vatro vatro

Labels
code quality
Projects
None yet
Milestone
1.0.0-next.1
Development

No branches or pull requests
1 participant
@vatro