Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

a little problem #28

Closed
AFEICHINA opened this issue Apr 8, 2023 · 1 comment
Closed

a little problem #28

AFEICHINA opened this issue Apr 8, 2023 · 1 comment

Comments

@AFEICHINA
Copy link

Hi Author,
I just wanted to let you know that I truly appreciate your work. It has been useful, and it's also very simple and easy to extend. Thank you for making it open source.
However, I did notice a small small small bug in the function pushSubmapIndices() when running in Debug mode. If dists is empty, pq.top() becomes unreachable. In Release mode, the compiler can fix this issue. Perhaps it would be possible to add some code to avoid this problem altogether?
Best regards.
Afei
@kennyjchen
Copy link
Collaborator

Hi @AFEICHINA -- great catch! I added a quick check on dists in v1.4.3 which should address it. Thanks for letting us know about this bug and for using our work. Let me know if that fixes it for you.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kennyjchen @AFEICHINA