mime-type set to application/octet-stream when uploading .glb files

[dim-anis]

Describe the bug
Attempting to upload a .glb file results in an error. mime-type defaults to application/octet-stream instead of model/gltf-binary.

To Reproduce
Steps to reproduce the behavior:

1. Extend assetOptions.permittedFileTypes with model/gltf-binary or .glb
2. Upload a .glb file through admin client
3. Errors with "mime-type application/octet-stream is not allowed"

Expected behavior
mime-type should be set to model/gltf-binary.

Environment (please complete the following information):

• @vendure/core version: 2.2.4
• Nodejs version: 20.12.0
• Database (mysql/postgres etc): postgres, local asset storage

[michaelbromley]

Hi,

Are you able to provide a sample .glb file I can use for testing?

[dim-anis]

Sure, @michaelbromley! Github doesn't support attaching .glb files, so here is a link to gdrive.

https://drive.google.com/file/d/1Q904UoC-MsH1UiQ2QdddNjOsjFel1bXk/view?usp=sharing

[michaelbromley]

Thanks. I can reproduce this using the provided file.

I think this may be a current limitation of browsers, according to:

• models mime type not supporting?  react-dropzone/react-dropzone#1273 (comment)

I think for now you may need to accept application/octet-stream for this to work

[jawngee]

This is happening with all file types with the s3 plugin as well. png, jpeg, etc all show up as application/octet-stream.

[michaelbromley]

@jawngee we are using the s3 plugin (with Minio) in prod in several projects and have not run into this. Are you able to provide steps to reproduce from a clean install?

[jawngee]

@michaelbromley

Yes, see here:

#3184 (comment)

A basic vendure install plus minio running in docker with the config in the linked comment.

[jawngee]

This is how it appears in minio's console:

[jawngee]

@michaelbromley
I think you need to pass ContentType to the upload object in the s3 storage strategy class. See my comment: #3184 (comment)

Thanks!