Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

0.9.0: some bug with reflinks #97

Closed
tunnckoCore opened this issue May 12, 2016 · 4 comments
Closed

0.9.0: some bug with reflinks #97

tunnckoCore opened this issue May 12, 2016 · 4 comments

Comments

@tunnckoCore
Copy link

tunnckoCore commented May 12, 2016

I noticed it a long time ago, but.. don't why didn't report it.

The cases is when you don't have any reflinks, add some then run verb, it adds it to the config, but didn't add them to the readme, so you should run verb one more time all is okey.

You maybe know that, b/c it also happening on your repos, noticed it few times - lastly on generate-mocha readme.

@jonschlinkert
Copy link
Member

Can you create the issue on the reflinks lib or helper-reflinks?

thanks

@jonschlinkert
Copy link
Member

also we already have issues related to this, I remember discussing it with you

@tunnckoCore
Copy link
Author

tunnckoCore commented May 12, 2016

Hm, i don't think it is helper-reflinks or reflinks related this time. For me it seems something in verb, that's why I posted it here. Some verb job, but i'm not sure what exactly. Some config loading, contexts loading, merging and etc stuff.

@tunnckoCore
Copy link
Author

tunnckoCore commented May 12, 2016

Because, say, we have raw .verb.md without reflinks like [foobar][] in it.

  1. we have run:true initially in package.json
  2. add [relike][] for example
  3. run verb - it writes the reflink to package.json, it generates the readme (okey), but it not adds the reflink to the generate readme (there where {%= reflinks(verb.reflinks) %} is placed), so you should run verb again and then all is okey (in second hit it sets [relike]: https://github.com/hybridables/relike, that is the expected)
[charlike@voltaire letta]$ verb
[01:14:57] initializing verb
[01:14:59] starting verb-readme-generator
[01:14:59] starting verb-readme-generator:default task
[01:15:00] updated package.json with: { reflinks: 
   [ 'relike',
     'relike-all',
     'relike-value',
     'letta-value',
     'co',
     'bluebird',
     'is-async-function',
     'common-callback-names' ] }
[01:15:00] finished verb-readme-generator:default task 1s
[01:15:00] finished verb-readme-generator 1s
[01:15:00] finished ✔
[charlike@voltaire letta]$ verb
[01:15:02] initializing verb
[01:15:04] starting verb-readme-generator
[01:15:04] starting verb-readme-generator:default task
                  ✔ created reference links from npm data +4s
[01:15:09] finished verb-readme-generator:default task 5s
[01:15:09] finished verb-readme-generator 5s
[01:15:09] finished ✔
[charlike@voltaire letta]$ verb
[01:15:13] initializing verb
[01:15:14] starting verb-readme-generator
[01:15:14] starting verb-readme-generator:default task
✔ created reference links from npm data +118ms
[01:15:16] finished verb-readme-generator:default task 1s
[01:15:16] finished verb-readme-generator 1s
[01:15:16] finished ✔

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants