From 27e94d41e1680c5c2854020b4e43638df633f6bc Mon Sep 17 00:00:00 2001 From: Will Binns-Smith Date: Thu, 20 Feb 2025 16:20:11 -0800 Subject: [PATCH] Update error-recovery test snapshots for alternative bundler [2/n] --- .../__snapshots__/error-recovery.test.ts.snap | 12 +++++ .../acceptance/error-recovery.test.ts | 50 +++++++++++++++++-- 2 files changed, 57 insertions(+), 5 deletions(-) diff --git a/test/development/acceptance/__snapshots__/error-recovery.test.ts.snap b/test/development/acceptance/__snapshots__/error-recovery.test.ts.snap index 729a695b8ed299..7534d58db68504 100644 --- a/test/development/acceptance/__snapshots__/error-recovery.test.ts.snap +++ b/test/development/acceptance/__snapshots__/error-recovery.test.ts.snap @@ -12,6 +12,18 @@ exports[`ReactRefreshLogBox default syntax > runtime error 1`] = ` 8 | return
" `; +exports[`ReactRefreshLogBox default syntax > runtime error: isWin32-false--isRspack-true 1`] = ` +"index.js (5:9) @ + + 3 | setInterval(() => { + 4 | i++ +> 5 | throw Error('no ' + i) + | ^ + 6 | }, 1000) + 7 | export default function FunctionNamed() { + 8 | return
" +`; + exports[`ReactRefreshLogBox turbo syntax > runtime error 1`] = ` "index.js (5:9) @ eval diff --git a/test/development/acceptance/error-recovery.test.ts b/test/development/acceptance/error-recovery.test.ts index 54c9808b625db1..879d74d8a81222 100644 --- a/test/development/acceptance/error-recovery.test.ts +++ b/test/development/acceptance/error-recovery.test.ts @@ -409,11 +409,9 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox %s', () => { await new Promise((resolve) => setTimeout(resolve, 1000)) await session.assertHasRedbox() - if (process.platform === 'win32') { - expect(await session.getRedboxSource()).toMatchSnapshot() - } else { - expect(await session.getRedboxSource()).toMatchSnapshot() - } + expect(await session.getRedboxSource()).toMatchSnapshot( + `isWin32-${process.platform === 'win32'}--isRspack-${Boolean(process.env.NEXT_RSPACK)}` + ) // Make a syntax error. await session.patch( @@ -446,6 +444,27 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox %s', () => { Expected '}', got ''" `) + } else if (process.env.NEXT_RSPACK) { + expect(redboxSource).toMatchInlineSnapshot(` + "./index.js + × Module build failed: + ├─▶ × + │ │ x Expected '}', got '' + │ │ ,-[TEST_DIR/index.js:7:1] + │ │ 4 | i++ + │ │ 5 | throw Error('no ' + i) + │ │ 6 | }, 1000) + │ │ 7 | export default function FunctionNamed() { + │ │ : ^ + │ │ \`---- + │ │ + │ + ╰─▶ Syntax Error + + Import trace for requested module: + ./index.js + ./pages/index.js" + `) } else { expect(redboxSource).toMatchInlineSnapshot(` "./index.js @@ -483,6 +502,27 @@ describe.each(['default', 'turbo'])('ReactRefreshLogBox %s', () => { Expected '}', got ''" `) + } else if (process.env.NEXT_RSPACK) { + expect(redboxSource).toMatchInlineSnapshot(` + "./index.js + × Module build failed: + ├─▶ × + │ │ x Expected '}', got '' + │ │ ,-[TEST_DIR/index.js:7:1] + │ │ 4 | i++ + │ │ 5 | throw Error('no ' + i) + │ │ 6 | }, 1000) + │ │ 7 | export default function FunctionNamed() { + │ │ : ^ + │ │ \`---- + │ │ + │ + ╰─▶ Syntax Error + + Import trace for requested module: + ./index.js + ./pages/index.js" + `) } else { expect(redboxSource).toMatchInlineSnapshot(` "./index.js