Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

tsconfig rewrite not respecting extends #13616

Closed
theprobugmaker opened this issue May 31, 2020 · 4 comments · Fixed by #13542
Closed

tsconfig rewrite not respecting extends #13616

theprobugmaker opened this issue May 31, 2020 · 4 comments · Fixed by #13542
Milestone

Comments

@theprobugmaker
Copy link

theprobugmaker commented May 31, 2020

Bug report

Describe the bug

I have a monorepo configured with a tsconfig.json file that shares common information but whenever I run the Next app it rewrites my tsconfig.json in the package and doesn't respect the extended one.

For example in the root I have a tsconfig.json file with excluded which has the node_modules folder, but when I run my client package which also has a tsconfig.json file it rewrites the excluded even tho it's extending the root config which already has this option.


I just noted something else, it's enforcing moduleResolution but it has been deprecated.

To Reproduce

You just need to have a tsconfig file somewhere and extend in the tsconfig.json file inside the next application.

Expected behavior

It should respect the extended config file and don't overwrite. I don't see forcing a tsconfig.json as the best solution here it would be nice to have at least warnings instead.

System information

  • OS: Windows
  • Version of Next.js: 9.4.4
  • Version of Node.js: 12.16.3
@timneutkens
Copy link
Member

This will be fixed by #13542

@theprobugmaker
Copy link
Author

Thank you very much

@Timer Timer added this to the iteration 6 milestone Jul 28, 2020
@Timer
Copy link
Member

Timer commented Jul 30, 2020

This was just fixed in 9.5.1, please upgrade!

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants