Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

OpenTelemetry: ignore bubble errors to avoid spamming traces #56625

Merged
merged 3 commits into from
Oct 12, 2023

Conversation

dvoytenko
Copy link
Member

The "bubble" errors are created here:

const err = new Error()
;(err as any).result = result
;(err as any).bubble = true
throw err

These errors do not appear to be true errors, but they tend to spam tracing. E.g.

image

@ijjk
Copy link
Member

ijjk commented Oct 9, 2023

Stats from current PR

Default Build
General Overall increase ⚠️
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
buildDuration 10.2s 10.2s N/A
buildDurationCached 6.3s 6.4s N/A
nodeModulesSize 172 MB 172 MB ⚠️ +1.09 kB
nextStartRea..uration (ms) 890ms 890ms
Client Bundles (main, webpack)
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
199-HASH.js gzip 27.5 kB 27.5 kB N/A
3f784ff6-HASH.js gzip 50.9 kB 50.9 kB
99.HASH.js gzip 182 B 182 B
framework-HASH.js gzip 45.3 kB 45.3 kB
main-app-HASH.js gzip 252 B 252 B
main-HASH.js gzip 32.9 kB 32.9 kB N/A
webpack-HASH.js gzip 1.75 kB 1.75 kB N/A
Overall change 96.7 kB 96.7 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
_app-HASH.js gzip 206 B 205 B N/A
_error-HASH.js gzip 182 B 180 B N/A
amp-HASH.js gzip 506 B 505 B N/A
css-HASH.js gzip 322 B 323 B N/A
dynamic-HASH.js gzip 2.57 kB 2.57 kB N/A
edge-ssr-HASH.js gzip 260 B 259 B N/A
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.35 kB 4.35 kB N/A
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 2.64 kB 2.63 kB N/A
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 384 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 1.08 kB 1.08 kB
Client Build Manifests
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
_buildManifest.js gzip 485 B 482 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
index.html gzip 528 B 530 B N/A
link.html gzip 540 B 543 B N/A
withRouter.html gzip 524 B 526 B N/A
Overall change 0 B 0 B
Edge SSR bundle Size
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 152 kB 152 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary dvoytenko/next.js dvoytenko/otel-internal-errors Change
middleware-b..fest.js gzip 624 B 623 B N/A
middleware-r..fest.js gzip 150 B 151 B N/A
middleware.js gzip 22.9 kB 22.9 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 1.92 kB 1.92 kB
Diff details
Diff for page.js

Diff too large to display

Diff for edge-ssr.js

Diff too large to display

Commit: 10ebe5b

@dvoytenko dvoytenko requested a review from ijjk October 11, 2023 15:50
@ijjk
Copy link
Member

ijjk commented Oct 11, 2023

Tests Passed

@kodiakhq kodiakhq bot merged commit 3da643a into vercel:canary Oct 12, 2023
@dvoytenko dvoytenko deleted the dvoytenko/otel-internal-errors branch October 12, 2023 21:07
@github-actions github-actions bot added the locked label Nov 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants