From c429f090fc413ff63d657cfc167c2dc87dd35263 Mon Sep 17 00:00:00 2001 From: Jude Gao Date: Sat, 1 Feb 2025 08:01:40 -0500 Subject: [PATCH] error msg is unused --- .../internal/helpers/get-error-by-type.ts | 3 +-- .../internal/helpers/stack-frame.ts | 12 ++++-------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/packages/next/src/client/components/react-dev-overlay/internal/helpers/get-error-by-type.ts b/packages/next/src/client/components/react-dev-overlay/internal/helpers/get-error-by-type.ts index 2b8157e35e9e0..09b0b5e09865d 100644 --- a/packages/next/src/client/components/react-dev-overlay/internal/helpers/get-error-by-type.ts +++ b/packages/next/src/client/components/react-dev-overlay/internal/helpers/get-error-by-type.ts @@ -31,8 +31,7 @@ export async function getErrorByType( frames: await getOriginalStackFrames( event.frames, getErrorSource(event.reason), - isAppDir, - event.reason.toString() + isAppDir ), } if (event.type === ACTION_UNHANDLED_ERROR) { diff --git a/packages/next/src/client/components/react-dev-overlay/internal/helpers/stack-frame.ts b/packages/next/src/client/components/react-dev-overlay/internal/helpers/stack-frame.ts index 77f02be7c2dad..d95d29aa8e9e6 100644 --- a/packages/next/src/client/components/react-dev-overlay/internal/helpers/stack-frame.ts +++ b/packages/next/src/client/components/react-dev-overlay/internal/helpers/stack-frame.ts @@ -15,15 +15,14 @@ export interface OriginalStackFrame extends OriginalStackFrameResponse { function getOriginalStackFrame( source: StackFrame, type: 'server' | 'edge-server' | null, - isAppDir: boolean, - errorMessage: string + isAppDir: boolean ): Promise { async function _getOriginalStackFrame(): Promise { const params = new URLSearchParams() params.append('isServer', String(type === 'server')) params.append('isEdgeServer', String(type === 'edge-server')) params.append('isAppDirectory', String(isAppDir)) - params.append('errorMessage', errorMessage) + for (const key in source) { params.append(key, ((source as any)[key] ?? '').toString()) } @@ -86,13 +85,10 @@ function getOriginalStackFrame( export function getOriginalStackFrames( frames: StackFrame[], type: 'server' | 'edge-server' | null, - isAppDir: boolean, - errorMessage: string + isAppDir: boolean ) { return Promise.all( - frames.map((frame) => - getOriginalStackFrame(frame, type, isAppDir, errorMessage) - ) + frames.map((frame) => getOriginalStackFrame(frame, type, isAppDir)) ) }