Skip to content

perf(turbopack): Use Arc<String> instead of String #7511

perf(turbopack): Use Arc<String> instead of String

perf(turbopack): Use Arc<String> instead of String #7511

Triggered via pull request May 28, 2024 06:02
@kdy1kdy1
synchronize #7772
kdy1/pack-2776
Status Failure
Total duration 1m 48s
Artifacts

bench-turbopack.yml

on: pull_request
Determine jobs to run
18s
Determine jobs to run
Turbopack rust check
51s
Turbopack rust check
Matrix: turbopack_rust_bench
Matrix: turbopack_bench_pr
Store benchmark result
0s
Store benchmark result
Cleanup  /  cleanup
4s
Cleanup / cleanup
Fit to window
Zoom out
Zoom in

Annotations

11 errors and 5 warnings
Turbopack rust check: crates/turbo-tasks-fs/src/embed/file.rs#L22
arguments to this function are incorrect
Turbopack rust check: crates/turbo-tasks-fs/src/embed/file.rs#L31
the trait bound `File: std::convert::From<RcStr>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/embed/file.rs#L10
the trait bound `fn(Arc<std::string::String>, Arc<std::string::String>) -> impl futures::Future<Output = Result<Vc<FileContent>, anyhow::Error>> {content_from_relative_path_inline_function}: IntoTaskFn<_, _>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/read_glob.rs#L29
the trait bound `fn(Arc<std::string::String>, Vc<FileSystemPath>, Vc<Glob>, bool) -> impl futures::Future<Output = Result<Vc<ReadGlobResult>, anyhow::Error>> {read_glob_inner_inline_function}: IntoTaskFn<_, _>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/glob.rs#L395
the trait bound `fn(Arc<std::string::String>) -> Result<Vc<Glob>, anyhow::Error> {Glob::new_inline}: IntoTaskFn<_, _>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/lib.rs#L883
the trait bound `fn(Vc<Box<(dyn FileSystem + 'static)>>, Arc<std::string::String>) -> Vc<FileSystemPath> {FileSystemPath::new_normalized_inline}: IntoTaskFn<_, _>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/lib.rs#L883
the trait bound `fn(Vc<FileSystemPath>, Arc<std::string::String>) -> impl futures::Future<Output = Result<Vc<FileSystemPath>, anyhow::Error>> {FileSystemPath::join_inline}: IntoTaskFn<_, _>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/lib.rs#L883
the trait bound `fn(Vc<FileSystemPath>, Arc<std::string::String>) -> impl futures::Future<Output = Result<Vc<FileSystemPath>, anyhow::Error>> {FileSystemPath::append_inline}: IntoTaskFn<_, _>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/lib.rs#L883
the trait bound `fn(Vc<FileSystemPath>, Arc<std::string::String>) -> impl futures::Future<Output = Result<Vc<FileSystemPath>, anyhow::Error>> {FileSystemPath::append_to_stem_inline}: IntoTaskFn<_, _>` is not satisfied
Turbopack rust check: crates/turbo-tasks-fs/src/lib.rs#L883
the trait bound `fn(Vc<FileSystemPath>, Arc<std::string::String>) -> impl futures::Future<Output = Result<Vc<FileSystemPathOption>, anyhow::Error>> {FileSystemPath::try_join_inline}: IntoTaskFn<_, _>` is not satisfied
Done
Process completed with exit code 1.
Determine jobs to run
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: peter-evans/find-comment@v2, peter-evans/create-or-update-comment@v2, actions/checkout@v3, technote-space/get-diff-action@v6. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Turbopack rust check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, arduino/setup-protoc@v2.1.0, ./.github/actions/cargo-sweep. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Turbopack rust check
Unexpected input(s) 'components', valid inputs are ['windows', 'targets', 'github-token', 'shared-cache-key', 'cache-key', 'save-cache']
Turbopack rust check
Unexpected input(s) 'components', valid inputs are ['windows', 'targets', 'github-token', 'shared-cache-key', 'cache-key', 'save-cache']
Done
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: peter-evans/find-comment@v2, peter-evans/create-or-update-comment@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.