fix: prevent circular structure exception #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
=======================================
Coverage 65.17% 65.17%
=======================================
Files 26 26
Lines 1407 1407
Branches 205 205
=======================================
Hits 917 917
Misses 487 487
Partials 3 3
Continue to review full report at Codecov.
|
jamesgeorge007
approved these changes
Jan 6, 2020
juanpicado
approved these changes
Jan 7, 2020
|
awesome @DanielRuf :) |
juanpicado
added a commit
to verdaccio/verdaccio
that referenced
this pull request
Jan 8, 2020
Fixed at verdaccio/monorepo#312 Fixes #1639 Co-Authored-By: Daniel Ruf <danielruf@users.noreply.github.com>
juanpicado
added a commit
to verdaccio/verdaccio
that referenced
this pull request
Jan 8, 2020
fix: converting circular structure to json (#1663) Fixed at verdaccio/monorepo#312 Fixes #1639 Co-Authored-By: Daniel Ruf <danielruf@users.noreply.github.com> Co-authored-by: Daniel Ruf <827205+DanielRuf@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type:
bugfix
Scope:
local-storage
The following has been addressed in the PR:
Description:
bunyan already sanitizes objects and prevents circular reference exceptions.
Resolves verdaccio/verdaccio#1639