Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

WebClient.close() does not return a Future or wait for resources to be released #2578

Open
mcanalesmayo opened this issue Feb 26, 2024 · 4 comments
Labels

Comments

@mcanalesmayo
Copy link

Version

4.3.3~

Context

Call to WebClient.close() does not wait for resources to be released.
Method signature was changed so that it returns a Future<Void> here #2197
But later was reverted here 8dda3de
I'd expect .close() to either return the Future<Void>, or (less ideally) block until the future finishes before returning.

Do you have a reproducer?

#2197 (comment)
8dda3de

Steps to reproduce

N/A

Extra

N/A

@tsegismont
Copy link
Contributor

@vietj can you give some context about why the futurization change was reverted?

@vietj
Copy link
Contributor

vietj commented Mar 8, 2024

I think because it was a breaking change, but well

@mcanalesmayo
Copy link
Author

@tsegismont @vietj so is there any plan to change it again to return the future?

@vietj
Copy link
Contributor

vietj commented Apr 2, 2024

yes I think we should

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

No branches or pull requests

3 participants