Remove explicit thread destruction code in the libasync driver. #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the discussion in #1835. Libasync now uses the default thread pool of std.parallelism, which is shut down automatically.
|
Wow that was a quick resolution - could you maybe release a new tag, s.t. these changes are propagated to the Project-Tester? Thanks! |
|
Let's wait with this until #1838 is merged, too. |
|
0.8.1-alpha.1 is now tagged and also available on code.dlang.org. |
Thanks a lot. I will try to keep an eye on the Project-Tester to check whether this solved our problems. |
s-ludwig
pushed a commit
that referenced
this pull request
Sep 2, 2017
…y_threads Remove explicit thread destruction code in the libasync driver. merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com> Conflicts: source/vibe/core/drivers/libasync.d
s-ludwig
pushed a commit
that referenced
this pull request
Sep 2, 2017
…y_threads Remove explicit thread destruction code in the libasync driver. merged-on-behalf-of: Sönke Ludwig <s-ludwig@users.noreply.github.com> Conflicts: source/vibe/core/drivers/libasync.d
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in #1835. Libasync now uses the default thread pool of
std.parallelism, which is shut down automatically.