Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

keyboard trap on caption button (MenuButton) #1758

Closed
gdkraus opened this issue Dec 19, 2014 · 2 comments
Closed

keyboard trap on caption button (MenuButton) #1758

gdkraus opened this issue Dec 19, 2014 · 2 comments

Comments

@gdkraus
Copy link

gdkraus commented Dec 19, 2014

Currently, as you tab through the interface, once you get to the caption button you get trapped in there. This can be very difficult, or even impossible, for users to get out of. I think the problem is src/js/menu.js line 185. The event.preventDefault(); should come inside of the if-then structure, only if space, enter, or escape is pressed. Otherwise the tab key is getting prevented too, which keeps users trapped there.

I would recommend this as a hotfix as it is creating fundamental barriers for certain user groups (keyboard-only users). It is preventing them from interacting with the player and also with any other content on the page where Video.JS is implemented. I can submit a patch for it if you would like, but since it's a hotfix I thought I'd check first.

@heff
Copy link
Member

heff commented Dec 19, 2014

Thanks Greg, a patch would be great, and if you can make it against the stable branch that would be best. We'll get this out ASAP.

@heff
Copy link
Member

heff commented Dec 19, 2014

This has been fixed and released in v4.11.3! See #1760

@heff heff closed this as completed Dec 19, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

No branches or pull requests

2 participants