Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Track metadata issues with video.js#4.12.12 #2436

Closed
chemoish opened this issue Aug 4, 2015 · 6 comments
Closed

Track metadata issues with video.js#4.12.12 #2436

chemoish opened this issue Aug 4, 2015 · 6 comments
Milestone

Comments

@chemoish
Copy link
Member

chemoish commented Aug 4, 2015

This works on Video.dev.js#4.12.12.

Video.js#4.12.12 throws the following:

screen shot 2015-08-04 at 3 03 02 pm

Maybe:

track.track['kind'] // from

track['track']['kind'] // to?
@chemoish chemoish changed the title Metadata issues with video.js#4.12.12 Track metadata issues with video.js#4.12.12 Aug 4, 2015
@heff
Copy link
Member

heff commented Aug 5, 2015

@gkatsev is this related to the one already being fixed or is it new? At least sounds related to #2412.

@chemoish if you want to try moving to 5.0, we're not mangling anymore so shouldn't be an issue. http://jsbin.com/sofiwu/edit?html,console,output

@gkatsev
Copy link
Member

gkatsev commented Aug 6, 2015

Yeah, it's a silly mistake. We could probably fix it as part of #2412 (yay gcc...)

@gkatsev gkatsev added this to the Text Tracks milestone Aug 10, 2015
@gkatsev
Copy link
Member

gkatsev commented Aug 13, 2015

This will be removed as part of #2468 and #2475.

@gkatsev
Copy link
Member

gkatsev commented Aug 21, 2015

This should be fixed in stable now. a02f0be

@chemoish
Copy link
Member Author

@gkatsev I am receiving an undefined track after this update.

4.12.14

Can you verify?

screen shot 2015-08-28 at 2 10 07 pm

https://github.com/videojs/video.js/blob/stable/src/js/tracks/text-track-list.js#L78

Captions seem to be turned on by default (Instead of the other way around). However, it looks like you can turn them off via the control bar.

@chemoish
Copy link
Member Author

chemoish commented Sep 1, 2015

Moving this to a new issue.

@chemoish chemoish closed this as completed Sep 1, 2015
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants