Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

menus aren't getting sized correctly anymore #3062

Closed
gkatsev opened this issue Feb 1, 2016 · 8 comments
Closed

menus aren't getting sized correctly anymore #3062

gkatsev opened this issue Feb 1, 2016 · 8 comments

Comments

@gkatsev
Copy link
Member

gkatsev commented Feb 1, 2016

vjs-menu's width is set to 0 but vjs-menu-content is supposed to be set to 24em but ends up getting set to 'inherit', so, menus aren't showing up properly, at least for the chapters menu.
also, vjs-selected isn't getting applied properly to the selected element.

@ogheo
Copy link

ogheo commented Feb 3, 2016

+1 for vjs-selected

@kylegilman
Copy link

I just discovered this problem too. Menu sizing and vjs-selected works in 5.5.3 but not in 5.6 and later.

@jorydekort
Copy link

When initialising videojs using javascript (see #3151 ) and changing css line 1131 in video-js.css by removing:

.vjs-chapters-button .vjs-menu {
  left: -10em;
  width: 0; }

The popup now shows! How ever the header is at the bottom. This should be on top of the list.

@jorydekort
Copy link

Sorry to keep posting here. But maybe other people are searching for a solution to this as well. Changing line 3578 in video.js from (in v5.7.1):

// Add the UI object's element to the container div (box)
// Having an element is not required
if (typeof component.el === 'function' && component.el()) {
      var childNodes = this.contentEl().children;
      var refNode = childNodes[index] || null;
      this.contentEl().insertBefore(component.el(), refNode);
}

to (from v5.2.1):

// Add the UI object's element to the container div (box)
// Having an element is not required
if (typeof component.el === 'function' && component.el()) {
      this.contentEl().appendChild(component.el());
}

seems to fix the order issue where the title shows above the list of items under Chapters.

@gkatsev gkatsev mentioned this issue Mar 8, 2016
2 tasks
@gkatsev gkatsev closed this as completed in feb7e26 Mar 9, 2016
@ogheo
Copy link

ogheo commented Apr 6, 2016

How about with vjs-selected? seems that vjs-selected is not fixed.

@gkatsev
Copy link
Member Author

gkatsev commented Apr 6, 2016

It seems to be getting applied correctly for me now, @Smilemd.
Can I ask about your setup? Would be good if you can put together a reduced test case.

@ogheo
Copy link

ogheo commented Apr 13, 2016

@gkatsev , i'm not very familiar with reduced test case, but i'll try to explain...

i use video.js + https://github.com/kmoskwiak/videojs-resolution-switcher

till the ~5.5.0 version vjs-select was working, here is an example:

vjs550

Later, vjs-select isn't applied (5.9.0):

vjs590

@ogheo
Copy link

ogheo commented Apr 15, 2016

sorry, it seems to be a videojs-resolution-switcher bug.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants