-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
menus aren't getting sized correctly anymore #3062
Comments
+1 for vjs-selected |
I just discovered this problem too. Menu sizing and vjs-selected works in 5.5.3 but not in 5.6 and later. |
When initialising videojs using javascript (see #3151 ) and changing css line 1131 in video-js.css by removing:
The popup now shows! How ever the header is at the bottom. This should be on top of the list. |
Sorry to keep posting here. But maybe other people are searching for a solution to this as well. Changing line 3578 in video.js from (in v5.7.1):
to (from v5.2.1):
seems to fix the order issue where the title shows above the list of items under Chapters. |
How about with vjs-selected? seems that vjs-selected is not fixed. |
It seems to be getting applied correctly for me now, @Smilemd. |
@gkatsev , i'm not very familiar with reduced test case, but i'll try to explain... i use video.js + https://github.com/kmoskwiak/videojs-resolution-switcher till the ~5.5.0 version vjs-select was working, here is an example: Later, vjs-select isn't applied (5.9.0): |
sorry, it seems to be a videojs-resolution-switcher bug. |
vjs-menu's width is set to 0 but vjs-menu-content is supposed to be set to 24em but ends up getting set to 'inherit', so, menus aren't showing up properly, at least for the chapters menu.
also,
vjs-selected
isn't getting applied properly to the selected element.The text was updated successfully, but these errors were encountered: