Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Video.js Grunt build proceess hangs on "minify" task on Windows #679

Closed
ghost opened this issue Aug 12, 2013 · 3 comments
Closed

Video.js Grunt build proceess hangs on "minify" task on Windows #679

ghost opened this issue Aug 12, 2013 · 3 comments

Comments

@ghost
Copy link

ghost commented Aug 12, 2013

Video.js Build on Windows Hangs on Minify Task,

Epected

Build process completed, files minified

Actual

I get no error or message, build process just hangs on Running "minify:source" (minify) task step.
An empty file called minified.video.js is created

Environment

  • Window7 x64
  • Node.js v0.10.15
@ghost
Copy link
Author

ghost commented Aug 12, 2013

The cause is "\n" when passing "output_wrapper" parameter, seems that windows cannot execute command which contains "\n" (i.e. it is pocessed as new line in console)

Gruntfile.js, line 213
+ ' --output_wrapper "/*! Video.js v' + version.full + ' ' + pkg.copyright + ' */\n (function() {%output%})();//@ sourceMappingURL=video.js.map"';

@heff
Copy link
Member

heff commented Aug 12, 2013

Thanks for digging into that. We could easily just drop that new line. Want to make a quick pull request and get credit?

@ghost
Copy link
Author

ghost commented Aug 15, 2013

Have sent relevant pull request

@heff heff closed this as completed in e520e1e Aug 19, 2013
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant