Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(play-toggle): missing svg play icon #8337

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Jul 2, 2023

Description

This PR fixes #8336, where the svg play icon is missing when player is initialized with class vjs-has-started.

Specific Changes proposed

  • add setIcon to the play-toggle component constructor

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

Svg play icon is missing when player is initialized with class `vjs-has-started`.

- add `setIcon` to the `play-toggle` component constructor

Fixes videojs#8336
@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #8337 (9e49bce) into main (2b0df25) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8337   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         113      113           
  Lines        7561     7562    +1     
  Branches     1818     1818           
=======================================
+ Hits         6252     6253    +1     
  Misses       1309     1309           
Impacted Files Coverage Δ
src/js/control-bar/play-toggle.js 86.48% <100.00%> (+0.37%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben merged commit b34cb2c into videojs:main Jul 4, 2023
@amtins amtins deleted the fix/play-toggle-svg-icon branch November 5, 2023 16:58
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when experimentalSvgIcons: true and the video don't start play can't see the play button
2 participants