Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(big-play-button): component remains displayed when seeking #8484

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

amtins
Copy link
Contributor

@amtins amtins commented Nov 4, 2023

Description

This issue happen when the player has the class vjs-show-big-play-button-on-pause and a seek occurs, resulting in the loadingSpinner being hidden behind the bigPlayButton.

Screencast.from.04.11.23.18.56.50.webm

Specific Changes proposed

  • Avoids displaying bigPlayButton while seeking

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

This issue happen when the `player` has the class `vjs-show-big-play-button-on-pause` and a `seek` occurs,
resulting in the `loadingSpinner` being hidden behind the `bigPlayButton`.

- Avoids displaying `bigPlayButton` while `seeking`
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #8484 (51fb00d) into main (d535e16) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8484   +/-   ##
=======================================
  Coverage   82.71%   82.71%           
=======================================
  Files         113      113           
  Lines        7589     7589           
  Branches     1826     1826           
=======================================
  Hits         6277     6277           
  Misses       1312     1312           

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@mister-ben mister-ben merged commit 92b5e79 into videojs:main Nov 28, 2023
8 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants