fix(build): Use escaped dbl quotes to support building on Windows #8681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mister-ben
changed the title
gkatsev
approved these changes
Apr 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8681 +/- ##
=======================================
Coverage 82.85% 82.85%
=======================================
Files 113 113
Lines 7647 7647
Branches 1839 1839
=======================================
Hits 6336 6336
Misses 1311 1311 ☔ View full report in Codecov by Sentry. |
This was referenced Aug 1, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using single quotes in the sass command doesn't work with Windows, causing sass to fail to locate imports.
Fixes #8149
Specific Changes proposed
Uses
\"rather than'within script strings in package.json.