Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Update karma dependencies #8743

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented May 21, 2024

Description

Updates karma dependencies. This includes an update to karma-firebox-launcher via videojs-generate-karma-config, however tests won't run on Firefox without manual intervention as karma-detect-browsers would also need to be updated (with the correct fief executable name) and that doesn't seem likely.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@mister-ben mister-ben changed the title chore: Update karma dependenciess chore: Update karma dependencies May 21, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.76%. Comparing base (978731e) to head (60d9f1f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8743      +/-   ##
==========================================
+ Coverage   83.15%   83.76%   +0.61%     
==========================================
  Files         120      120              
  Lines        7995     7995              
  Branches     1924     1924              
==========================================
+ Hits         6648     6697      +49     
+ Misses       1347     1298      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added the needs: LGTM Needs one or more additional approvals label May 28, 2024
@adrums86 adrums86 merged commit 42e167c into videojs:main May 30, 2024
12 of 13 checks passed
@adrums86 adrums86 mentioned this pull request May 30, 2024
9 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
needs: LGTM Needs one or more additional approvals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants