Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: Reorder SASS styles to address deprecation #8821

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

mister-ben
Copy link
Contributor

@mister-ben mister-ben commented Jul 30, 2024

Description

Some of the existing rules would be interpreted differently in a future version of SASS. In the current version, they trigger a deprecation warning. See https://sass-lang.com/documentation/breaking-changes/mixed-decls/

Specific Changes proposed

Re-orders rules to maintain current output and remove warnings. The output of video-js.css and video-js.min.css remains the same.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.12%. Comparing base (c4007db) to head (ad226b1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8821   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files         120      120           
  Lines        8052     8052           
  Branches     1931     1931           
=======================================
  Hits         6693     6693           
  Misses       1359     1359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mister-ben mister-ben added the patch This PR can be added to a patch release. label Jul 30, 2024
@mister-ben mister-ben merged commit 57c27f8 into videojs:main Jul 31, 2024
12 checks passed
@gkatsev gkatsev mentioned this pull request Sep 9, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
patch This PR can be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants