Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: update VHS to v3.14.1 #8860

Merged
merged 3 commits into from
Sep 10, 2024
Merged

fix: update VHS to v3.14.1 #8860

merged 3 commits into from
Sep 10, 2024

Conversation

adrums86
Copy link
Contributor

@adrums86 adrums86 commented Sep 9, 2024

Description

Update VHS to v3.14.1 for a VTT timing fix detailed here: videojs/http-streaming#1537

Specific Changes proposed

Update the VHS package to v.3.14.1.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (1e2ea61) to head (feade03).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8860   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files         120      120           
  Lines        8066     8066           
  Branches     1937     1937           
=======================================
  Hits         6712     6712           
  Misses       1354     1354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrums86
Copy link
Contributor Author

Thank you @Essk!

@adrums86 adrums86 requested a review from wseymour15 September 10, 2024 16:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants