Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enforce saving fit data to expected filename #24

Open
duetosymmetry opened this issue Aug 5, 2024 · 0 comments
Open

Enforce saving fit data to expected filename #24

duetosymmetry opened this issue Aug 5, 2024 · 0 comments

Comments

@duetosymmetry
Copy link
Collaborator

In base class SurFinBH, a model named with name <name> is expected to be loaded from fit_<name>.h5:

h5file = h5py.File('%s/fit_%s.h5'%(DataPath(), name), 'r')

But when fetching in DownloadData, the destination filename is just taken from the URL:

print('Downloading %s data'%name)
data_url = fits_collection[name].data_url
filename = data_url.split('/')[-1]

Maybe we should save to fit_<name>.h5 so that data_url isn't restricted.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant