Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove polyfills #983

Open
bdougherty opened this issue Apr 2, 2024 · 1 comment
Open

Remove polyfills #983

bdougherty opened this issue Apr 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@bdougherty
Copy link
Contributor

bdougherty commented Apr 2, 2024

We include Promise and WeakMap polyfills to the library, but both have been supported for ~10 years now. Removing both means that we can reduce the bundle size and remove all external dependencies for the production build.

Will need to think a little bit about possible implications of this changing, and of course it would need to be a major version.

@bdougherty bdougherty self-assigned this Apr 2, 2024
@bdougherty bdougherty added the enhancement New feature or request label Apr 2, 2024
@jybleau
Copy link
Contributor

jybleau commented Jun 27, 2024

That would essentially drop support for IE 11: a good thing.
And it seems IE 11 only needs Promise, since it supports WeakMap

BTW, this part of the code is for IE8-9 and can probably be pruned since the player does not support IE<11.

@bdougherty bdougherty removed their assignment Oct 26, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants