Add better string detection

vimeo · Jan 7, 2020 · ce5917c · ce5917c
1 parent b351df0
commit ce5917c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOpAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/BinaryOpAnalyzer.php
@@ -575,7 +575,11 @@ function ($c) {
             if ($stmt_left_type
                 && $stmt_right_type
                 && ($stmt_left_type->getId() === 'non-empty-string'
-                    || $stmt_right_type->getId() === 'non-empty-string')
+                    || $stmt_right_type->getId() === 'non-empty-string'
+                    || ($stmt_left_type->isSingleStringLiteral()
+                        && $stmt_left_type->getSingleStringLiteral()->value)
+                    || ($stmt_right_type->isSingleStringLiteral()
+                        && $stmt_right_type->getSingleStringLiteral()->value))
             ) {
                 $stmt_type = new Type\Union([new Type\Atomic\TNonEmptyString()]);
             } else {