[Bug] Picking for custom layers should be optional and shouldn't log warnings

[gregtayl]

Description

If you create a custom layer (inheriting from Layer) but do not include the 'picking' module you get a warning: "hook.js:608 luma.gl: Module picking not found". This is caused by picking logic in the base Layer class, specifically the call in _postUpdate function to: setShaderModuleProps({picking}).

Ideally no warning should be raised for custom layers that don't require interactivity/picking. One workaround is to override the setShaderModuleProps function in your custom layer to intercept/swallow this call, however, it seems like there should be a way to disable picking altogether that would avoid all of picking related logic/methods/etc.. Perhaps moving the picking logic to a higher-level PickableLayer class instead of including it in the base Layer class might be another way to approach this?

Flavors

• Script tag
• React
• Python/Jupyter notebook
• MapboxOverlay
• GoogleMapsOverlay
• CartoLayer
• ArcGIS

Expected Behavior

Ideally no warnings would be logged when creating a custom layer that doesn't require picking. Superfluous warnings make it easy for other important warnings to be overlooked.

Steps to Reproduce

Create a custom layer, but do not include the picking module.

Environment

• Framework version: 9.0.36
• Browser: any
• OS: any

Logs

No response