Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature] Light theme #24

Closed
ngocanhtve opened this issue Feb 22, 2024 · 5 comments · Fixed by #44
Closed

[Feature] Light theme #24

ngocanhtve opened this issue Feb 22, 2024 · 5 comments · Fixed by #44
Assignees
Labels
enhancement New feature or request priority medium

Comments

@ngocanhtve
Copy link

First of all, thank you for a very nice application. It would be great if the app supported a light theme, preferably a follow system option.
Thank you!

@vishal2376
Copy link
Owner

Currently app looks bad in light theme. So i am doing experiment with different color shades that's why it still not implemented.

I want to make themes look like premium apps (it willl remain free in my app)

and Thanks for appreciation 😊

@vishal2376 vishal2376 added enhancement New feature or request priority medium labels Feb 22, 2024
@vishal2376
Copy link
Owner

20240225_121327.jpg

@ngocanhtve I don't use light theme, so i want feedback from light theme users

please let me know, if you find any issues like readability issue, color contrast, etc

@ngocanhtve
Copy link
Author

please let me know, if you find any issues like readability issue, color contrast, etc

It's good. Sir!

@ngocanhtve
Copy link
Author

ngocanhtve commented Feb 25, 2024

I think a slightly lighter color range would be more soothing to the eyes. Because I often see Material You apps have a rather light color range.
But basically the current color range is already good.

@vishal2376 vishal2376 self-assigned this Mar 5, 2024
@vishal2376
Copy link
Owner

Demo - https://x.com/vishal2376/status/1765010912342143293?s=20

@vishal2376 vishal2376 linked a pull request Mar 6, 2024 that will close this issue
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request priority medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants