Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

there are many many places where processor arch each with their own list of arches #20134

Open
cyrush opened this issue Dec 16, 2024 · 1 comment
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood

Comments

@cyrush
Copy link
Member

cyrush commented Dec 16, 2024

Describe the bug

When reviewing Mark's thorough PR to add arm64 arch support, I was surprised at the amount of places we have processor arch here were two of the surprises:

src/common/misc/InstallationFunctions.C

Many of these look very old and we are missing new ones (ppc64le)
I think this was used to download new versions of VisIt from the GUI.
I don't think that is supported well, so maybe we don't need this function anymore?

https://github.com/visit-dav/visit/blob/develop/src/test/tests/unit/launcher.py
In this case, maybe there isn't much to suggest. I guess we could provide a Python API call that lists all the valid archs.

Related but already resolve:

We had an issue with launch on rzansel that was due to ppc64le case missing.

@cyrush cyrush added bug Something isn't working likelihood medium Neither low nor high likelihood impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) labels Dec 16, 2024
@markcmiller86
Copy link
Member

Just to be clear, all the instances I found and changed were based on textual analysis (e.g. grep) and not on any specific functionality failing other than install paths having incorrect architecture moniker. So, there is a chance that some of my changes were to obsolete or otherwise irrlevant code. It was just easier for me to fix everything I could find than try to figure out which instances correlate with which functionality.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working impact medium Productivity partially degraded (not easily mitigated bug) or improved (enhancement) likelihood medium Neither low nor high likelihood
Projects
None yet
Development

No branches or pull requests

2 participants