annot_macros_allmacros_12 fails when not run in the nightly location

[biagas]

Describe the bug

This test uses a full path to the data file to display as annotation text.
The path differs if a developer runs the test from their own checkout, and thus the test fails.
It is a bit of an annoyance to discover there were errors in the test suite when testing locally only to discover this was the only failure.

It would be nice if this test either only used the db name, or filtered out the path to display only the root of the test suite.

There are places in our testing with text output that filters full paths to replace parts of them with VISIT_TOP_DIR so that the outputs will be the same everywhere. This use case is different, because it isn't textual output, but text added to the annotations being rendered.
Nevertheless, it should be possible to use the same filtering in this case before setting it as the text to be used in the annotation.

Expected behavior

The test shouldn't fail when run from a different location than the nightlies.

[markcmiller86]

Oh, wow. Thats bad! Sheesh, why can't all developers just run things with the same paths I do 😝? That would simplify things a lot.

Ok, one quick option...we can just forgo the test of $fulldbname macro. Its probably not really doing anything more useful that the filename macro anyways.

[markcmiller86]

Or, better yet, we can skip that test when not running on the tier 1 platform, call AddSkipCase() just prior to the Test() call for it.

[biagas]

Tier 1 platform? Does that mean poodle? Or poodle + nightly location?

[markcmiller86]

So, include this code in the .py file...

def allmacros():
    """All non-empty macros in all text modes"""

    #
    # Loop through through all macros rendering with default format
    # both as 2D text and as 3D text. We skip "lod", "xunits", "yunits",
    # "zunits" and "varunits" because the input database has no values
    # specified for these.
    #
    macroNames = ("time", "cycle", "index", "numstates", "dbcomment",
        "vardim", "numvar", "topodim", "spatialdim", "varname",
        "meshname", "filename", "fulldbname", "xlabel", "ylabel", "zlabel")

    if sys.platform.startswith("win"):
        AddSkipCase("annot_macros_allmacros_12")

    text2d = create_text2d_annot()
    text3d = CreateAnnotationObject("Text3D")
    text3d.heightMode = text3d.Relative
    text3d.relativeHeight = 0.03

[markcmiller86]

It should really skip when platform is not the tier1 platform. But, am busy with other items and don't have time to provide precise logic. I think you get the idea though.

[biagas]

Actually, that doesn't solve the case where I am running on poodle, but not in the nightly location.

No hurry on this.