Skip to content

fix(plugin-vue): re-create filters after updating options #246

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2023
Merged

fix(plugin-vue): re-create filters after updating options #246

merged 2 commits into from
Oct 1, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented Aug 29, 2023

Description

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sxzz sxzz requested a review from haoqunjiang August 29, 2023 19:58
haoqunjiang
haoqunjiang requested changes Sep 28, 2023
View reviewed changes
@sxzz sxzz force-pushed the fix/update-filter branch from d9e913b to e85ae9f Compare September 30, 2023 12:41
@sxzz sxzz force-pushed the fix/update-filter branch from e85ae9f to 0b9bc6f Compare October 1, 2023 14:28
@sxzz sxzz requested a review from haoqunjiang October 1, 2023 14:28
@haoqunjiang haoqunjiang merged commit c383503 into main Oct 1, 2023
@haoqunjiang haoqunjiang deleted the fix/update-filter branch October 1, 2023 14:32
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@haoqunjiang haoqunjiang haoqunjiang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxzz @haoqunjiang