Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(plugin-vue): allow disabling transformAssetUrls #326

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 1, 2024

Description

In Astro, it has its own image handling that returns image imports as an object, rather than a string. This would break when Vue automatically transform asset reference to imports.

However, when we try to disable with transformAssetUrls: false, it didn't work due to the logic flow, and always enabled it anyways. This PR fixes it.

There is a workaround today (withastro/astro#9328 (comment)), but I figured it's better to improve this anyway.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label Jan 1, 2024
@yoyo837
Copy link

yoyo837 commented Jan 3, 2024

Can this be merged?

@sxzz sxzz changed the title fix: allow disabling transformAssetUrls fix(plugin-vue): allow disabling transformAssetUrls Feb 9, 2024
@sxzz sxzz merged commit 0ff6fb7 into main Feb 9, 2024
1 check passed
@sxzz sxzz deleted the fix-transformAssetUrls-false branch February 9, 2024 17:51
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants