Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Switch to JSX runtime transform in preact-ts template #10061

Merged
merged 1 commit into from
Sep 10, 2022

Conversation

marvinhagemeister
Copy link
Contributor

Description

Switch the preact-ts template over to the JSX runtime transform, similar to the react-ts template. This allows us to drop the preact.d.ts file too.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@marvinhagemeister marvinhagemeister changed the title Preact-TS: Switch to JSX runtime transform feat: Switch to JSX runtime transform in preact-ts template Sep 10, 2022
@patak-dev patak-dev merged commit bf69063 into vitejs:main Sep 10, 2022
@patak-dev patak-dev added the p2-nice-to-have Not breaking anything but nice to have (priority) label Sep 10, 2022
@marvinhagemeister marvinhagemeister deleted the preact-jsx-runtime branch September 10, 2022 12:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants