Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(html): allow self closing on non-void elements #10478

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 15, 2022

Description

Fix #10439

Allow <self-close /> for non-void elements. Technically this is not in par of the HTML spec but it was a regression that used to work before we switch to parse5.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Oct 15, 2022
@patak-dev patak-dev merged commit 29292af into main Oct 15, 2022
@patak-dev patak-dev deleted the fix-html-self-close branch October 15, 2022 11:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-closing tags of non-void elements no longer works in vite 3.1.0
2 participants