Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: revert es-module-lexer version #10614

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

sapphi-red
Copy link
Member

Description

It seems es-module-lexer 1.0.4-1.0.5 has a bug affecting histoire.
Reverting the version worked https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3311221053/jobs/5466393115.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the regression The issue only appears after a new release label Oct 24, 2022
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 24, 2022

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
rakkas ✅ success
svelte ✅ success
vite-plugin-ssr ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@patak-dev patak-dev merged commit cffe5c9 into vitejs:main Oct 24, 2022
@sapphi-red
Copy link
Member Author

I've reported upstream: guybedford/es-module-lexer#140

@sapphi-red sapphi-red deleted the fix/revert-es-module-lexer branch October 24, 2022 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants