Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: make viteMetadata property of RenderedChunk optional #11768

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Jan 20, 2023

Description

viteMetadata property doesn't exist when a plugin is used with rollup. So the property should be optional.
refs #11511

https://github.com/vitejs/vite-ecosystem-ci/actions/runs/3964905502/jobs/6794171075#step:8:476

https://discord.com/channels/804011606160703521/1065932582946086953/1065932585924038706

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red
Copy link
Member Author

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Jan 20, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ❌ failure
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
previewjs ❌ failure
qwik ❌ failure
rakkas ✅ success
sveltekit ❌ failure
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ❌ failure
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

@sapphi-red sapphi-red added bug regression The issue only appears after a new release labels Jan 20, 2023
@sapphi-red sapphi-red added this to the 4.1 milestone Jan 27, 2023
@sapphi-red sapphi-red merged commit 128f09e into vitejs:main Jan 27, 2023
@sapphi-red sapphi-red deleted the fix/make-vite-metadata-optional branch February 18, 2023 12:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants