Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(css): respect esbuild.charset when minify #13190

Merged

Conversation

sapphi-red
Copy link
Member

Description

#12565 changed to use charset: 'utf8' by default but didn't respect esbuild.charset when it's set.
This PR fixes that.

refs #12993

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels May 13, 2023
@stackblitz
Copy link

stackblitz bot commented May 13, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 4fd35ed into vitejs:main May 13, 2023
@sapphi-red sapphi-red deleted the fix/respect-charset-for-minify-css branch May 13, 2023 16:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants