Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(create-vite): support bun as a script runner #13402

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

paperclover
Copy link
Contributor

@paperclover paperclover commented Jun 2, 2023

Description

This fixes some edge cases when using bun x create-vite to initialize projects. create-vote already detects Bun, but if you chose an option like customize with create-vue (which runs create-vue), it would run the incorrect command.

Additional context

bun create doesn't work like npm|yarn|pnpm create; instead of using the npm registry it has it's own set of templates. This is the main change.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a fine change to me

@bluwy bluwy added the p2-nice-to-have Not breaking anything but nice to have (priority) label Jun 3, 2023
@patak-dev patak-dev merged commit 471fba2 into vitejs:main Jun 3, 2023
@paperclover paperclover deleted the bun-create-vite branch June 3, 2023 16:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants