Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(template): eliminate the error that occurs when enabling eslint-plugin-markdown #13942

Merged
merged 1 commit into from
Jul 25, 2023
Merged

fix(template): eliminate the error that occurs when enabling eslint-plugin-markdown #13942

merged 1 commit into from
Jul 25, 2023

Conversation

liby
Copy link
Contributor

@liby liby commented Jul 24, 2023

Description

The following code generated by Vite will encounter an error when the project is enabled with https://github.com/eslint/eslint-plugin-markdown.

image

Additional context

It doesn't seem necessary to introduce https://github.com/eslint/eslint-plugin-markdown for the Vite project. I have checked other code generated by Vite and haven't found other similar issues so far.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jul 24, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev merged commit 6251a66 into vitejs:main Jul 25, 2023
@liby liby deleted the bugfix/fix-eslint-error branch July 26, 2023 09:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants